(7/308) 41 - CheckStyle package.html broken 2

Recreation Steps:
1. Configure the CheckStyle plug-in such that the Javadoc
package HTML is required:
checkstyle.require.packagehtml=yes
2. Check a buffer that doesn't have a package.html.
3. In the error list, double-click the entry reporting "missing
package documentation file". jEdit "opens" the non-existent
file.
4. Try to check the buffer again.

CheckStyle no longer works. The problem appears to be in
ErrorManager.java, line 104. In the case where the
package.html error is being reported, the line is zero. With
the -1, it ends up passing -1 for the line number into
addError. This only seems to be a problem if there is a
buffer representing package.html open -- in that case, an
ArrayIndexOutOfBoundsException is thrown, and the plug-
in stops processing the file.

The attached version of ErrorManager.java has a potential
fix which guarantees the line is >= 0.

Comments